Skip to content

[Merged by Bors] - Use a watch for waiting for deleted objects rather than polling #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Use a watch for waiting for deleted objects rather than polling #452

wants to merge 4 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Aug 2, 2022

Description

Please add a description here. This will become the commit message of the merge request later.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr self-assigned this Aug 2, 2022
@nightkr nightkr requested a review from a team August 2, 2022 15:48
maltesander
maltesander reviewed Aug 2, 2022
View reviewed changes
@nightkr nightkr requested a review from maltesander August 11, 2022 12:19
maltesander
maltesander approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nightkr
Copy link
Member Author

nightkr commented Aug 11, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 11, 2022
@nightkr
Use a watch for waiting for deleted objects rather than polling (#452)
c8180b3 
## Description

*Please add a description here. This will become the commit message of the merge request later.*



Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
@bors
Copy link
Contributor

bors bot commented Aug 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Use a watch for waiting for deleted objects rather than polling [Merged by Bors] - Use a watch for waiting for deleted objects rather than polling Aug 11, 2022
@bors bors bot closed this Aug 11, 2022
@bors bors bot deleted the feature/delete-watch branch August 11, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@nightkr nightkr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nightkr @maltesander